Skip to content

✨ Clicking Project Find result should place cursor in correct location #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
austincondiff opened this issue Dec 9, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request find navigator

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Dec 9, 2023

Description

When performing a search in the find navigator and a list of results are presented, the user clicks a result and when it opens the corresponding file. the cursor should be positioned at the end of the result.

@tom-ludwig
Copy link
Member

@austincondiff

@austincondiff austincondiff moved this from 🆕 New to 🏃‍♂️ In Progress in CodeEdit Project Dec 10, 2023
@austincondiff
Copy link
Collaborator Author

@tom-ludwig this one is assigned to you. Where do we stand on this one?

If we don't already, we need a way to move the cursor / modify selected ranges and add emphasis layers externally. Maybe we allow for setting the current find match index externally, because this functionality already exists within CESE for in-editor find. When we do not focus the find panel, and we go to the next match, it scrolls to and flashes the range and fades out into a text selection.

@tom-ludwig
Copy link
Member

That was the plan. This issue was blocked by the Emphasis API and the lack of find-and-replace in CESE. Once we complete find-and-replace in CESE—probably next week—this should be a quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request find navigator
Projects
Status: 🏃‍♂️ In Progress
Development

No branches or pull requests

2 participants