Skip to content

✨ Clicking Project Find result should highlight instance of query text #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
austincondiff opened this issue Dec 9, 2023 · 2 comments
Assignees

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Dec 9, 2023

Description

When performing a search in the find navigator and a list of results are presented, the user clicks a result and when it opens the corresponding file, the instance of the query text should be highlighted – not to be confused with selected.

Related issues

Additional Context

We have been discussing the need for a highlight API. We currently have the ability to highlight matching brackets (CodeEditApp/CodeEditTextView#67). The bracket highlight bounces and then disappears, but we also need the ability to bounce and not disappear for this to work correctly. Then when the user clicks or navigates with the keyboard into the editor, we should hide/clear the highlight.

For an example of how this works, do a project find in Xcode and click on a result. Take note of how the highlight bounces and remains present until the user clicks into the editor.

Screenshots

image
@thecoolwinter
Copy link
Collaborator

thecoolwinter commented Dec 10, 2023

Blocked by CodeEditApp/CodeEditTextView#6

Not blocked anymore, this has been merged.

@austincondiff
Copy link
Collaborator Author

See this comment. #1504 (comment)

The same applies here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏃‍♂️ In Progress
Development

No branches or pull requests

3 participants