Skip to content

✨ Jump Bar Overflow Accordion Effect #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
austincondiff opened this issue Mar 25, 2022 · 2 comments
Open

✨ Jump Bar Overflow Accordion Effect #241

austincondiff opened this issue Mar 25, 2022 · 2 comments
Assignees
@swiftlysingh
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 25, 2022 •
edited
Loading

Description

The jump bar was not previously not handling overflow per #182, but was later fixed in #186, which was a quick fix to allow for the jump bar to be scrollable.

Xcode handles it's overflow a little differently with an accordion-like effect where it condenses each item down to an icon if necessary and when items are hovered over they are expanded.

This is a small detail, but we should be handling overflow this way as well.

Screenshots

CodeEdit currently

Screen.Recording.2025-05-05.at.11.05.19.AM.mov

Target behavior

Screen.Recording.2025-05-05.at.11.00.45.AM.mov
@austincondiff austincondiff added the enhancement New feature or request label Mar 25, 2022
@austincondiff austincondiff changed the title [FEAT] - Breadcrumb overflow accordion effect ✨ Breadcrumb overflow accordion effect Mar 31, 2022
@stale stale bot added the wontfix This will not be worked on label May 30, 2022
@CodeEditApp CodeEditApp deleted a comment from stale bot Jun 1, 2022
@stale stale bot removed the wontfix This will not be worked on label Jun 1, 2022
@stale stale bot added the wontfix This will not be worked on label Aug 1, 2022
@CodeEditApp CodeEditApp deleted a comment from stale bot Aug 1, 2022
@stale stale bot removed the wontfix This will not be worked on label Aug 1, 2022
@Wouter01 Wouter01 moved this from 🆕 New to 📋 Todo in CodeEdit Project Feb 16, 2023
xinix909 pushed a commit to xinix909/CodeTransfer that referenced this issue Sep 7, 2024
@Sophiahooley @FastestMolasses
Toggle comment for current line via CMD + / (CodeEditApp#241)
dae56c8 
This change implements the functionality of <kbd>⌘</kbd> <kbd>/</kbd>
for single line comments. It allows you to toggle between commented and
uncommented for the line the cursor is currently on when you press
<kbd>⌘</kbd> <kbd>/</kbd>.

To do so, I implemented a `keyDown` event recognizer, which listens for
when the relevant keys are pressed. If <kbd>⌘</kbd> <kbd>/</kbd> is
pressed, it calls a method called `commandSlashCalled()`, which decides
which toggle is supposed to happen depending on if the line is already
commented or not. It also addresses the situation of special cases of
languages like HTML, which need a comment at the beginning and end of
the line (essentially a `rangeComment`) to comment a single line.

### Related Issues

- CodeEditApp#38

This PR accomplishes part of CodeEditApp#38. I talked with some of the project
leads (@FastestMolasses) and they said it makes sense to break CodeEditApp#38 into
a couple different issues (I.e. single-line vs highlighted chunks, etc).
Single-line comment toggling is completed as of this PR but commenting
highlighted code still needs to be completed.

### Checklist

- [x] I read and understood the [contributing
guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md)
as well as the [code of
conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)
- [x] The issues this PR addresses are related to each other
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] My changes are all related to the related issue above
- [x] I documented my code

### Screenshots

<img width="626" alt="Screenshot 2024-04-19 at 5 44 24 PM"
src="https://github.com/CodeEditApp/CodeEditSourceEditor/assets/143217945/1200a5c1-d8ea-48a4-9704-70db7aa23fc7">

---------

Co-authored-by: Abe <abe.malla8@gmail.com>
@austincondiff austincondiff added the good first issue Good for newcomers label Apr 19, 2025
@austincondiff austincondiff changed the title ✨ Breadcrumb overflow accordion effect ✨ Jump Bar Overflow Accordion Effect Apr 19, 2025
@swiftlysingh
Copy link

Is anyone currently working on this issue? I'd be happy to take a look at it if not.

@austincondiff austincondiff moved this from 📋 Todo to 🏃‍♂️ In Progress in CodeEdit Project May 7, 2025
@austincondiff
Copy link
Collaborator Author

@swiftlysingh assigned to you. Let me know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swiftlysingh swiftlysingh

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
CodeEdit Project
Status: 🏃‍♂️ In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@austincondiff @swiftlysingh