Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Drag to reorder sidebar dock icons #41

Closed
austincondiff opened this issue Mar 17, 2022 · 6 comments
Closed

✨ Drag to reorder sidebar dock icons #41

austincondiff opened this issue Mar 17, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 17, 2022

Icons in each sidebar’s dock needs to be able to be reordered via drag and drop.

image

Please note that this will need to be applied to the navigator sidebar (left) and the inspector sidebar (right).

Also, keep in mind that we will eventually need the ability to drag these icons down to create a split sidebar like this. This is not required for this PR but we will need this at some point.

This should be saved and synced across all open workspaces, persisting after the app is closed and reopened. It should not be in the preferences UI or in preferences.json. In the View menu, we should have an item labeled “Reset Workspace Layout To Default” that resets this setting to default.

This setting should track icon location per pane, per sidebar. So for example, it can look like this:

  • Navigator Sidebar
    • panel 1
      • project
      • source control
      • find
    • panel 2
      • debug
      • tasks
      • symbols
  • Inspector Sidebar
    • panel 1
      • source control
      • file
      • quick help
@austincondiff austincondiff added enhancement New feature or request good first issue Good for newcomers labels Mar 17, 2022
@lukepistrol lukepistrol changed the title Drag to reorder sidebar dock icons [FEAT] - Drag to reorder sidebar dock icons Mar 21, 2022
@jav-solo
Copy link
Contributor

This can be assigned to me. I may need a little guidance as far as where to put the .json config file, but should be able to handle this.

@jasonplatts
Copy link
Collaborator

Thanks @jav-solo!

@austincondiff
Copy link
Collaborator Author

@jav-solo Just use app storage for now, we can worry about an external file later.

Also, this is related to #256, do you think it is a good idea to do this at the same time?

@jav-solo
Copy link
Contributor

Yeah, I think that's a good idea!

@austincondiff
Copy link
Collaborator Author

Perfect, if you are working on this please submit a draft PR.

@austincondiff austincondiff changed the title [FEAT] - Drag to reorder sidebar dock icons ✨ Drag to reorder sidebar dock icons Mar 31, 2022
@jav-solo
Copy link
Contributor

jav-solo commented Apr 19, 2022

I have submitted a PR Review for the re-ordering of the sidebar and inspector icons. The persistence piece is not something I will be able to complete at this time. Please re-assign this issue to someone who can or create anther issue to implement the persistence settings.

@jav-solo jav-solo removed their assignment Apr 19, 2022
@stale stale bot added the wontfix This will not be worked on label Jun 19, 2022
@CodeEditApp CodeEditApp deleted a comment from stale bot Jun 19, 2022
@austincondiff austincondiff removed the wontfix This will not be worked on label Jun 19, 2022
Repository owner moved this from Todo to Done in CodeEdit Project Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: 🏁 Complete
Development

No branches or pull requests

3 participants