Feature reorder dock items

[jav-solo]

Description

Adding the ability to re-order the dock icons in the sidebar

Related Pull Requests

[WIP] Feature drag and drop icons

Related Issues

• ✨ Drag to reorder sidebar dock icons #41

Checklist

• I read and understood the contributing guide as well as the code of conduct
• My changes generate no new warnings
• My code builds and runs on my machine
• Review requested

Screenshots

navigator-sidebar-demo.mov

inspector-demo.mov

[austincondiff]

Please note that this will need to be applied to the navigator sidebar (left) and the inspector sidebar (right).

Also, keep in mind that we will eventually need the ability to drag these icons down to create a split sidebar like this. This is not required for this PR but we will need this at some point.

[austincondiff]

Also, I believe @lilingxi01 is working on dragging to reorder tabs (please confirm). You might coordinate together so that we are consistent in the approach we are taking to do both of these.

[nanashili]

We should just save the list in the preferences, so when the user opens the app again they can get the previous icon positions again.

[austincondiff]

This should be saved and synced across all open workspaces, persisting after the app is closed and reopened. It should not be in the preferences UI or in preferences.json. In the View menu, we should have an item labeled “Reset Workspace Layout To Default” that resets this setting to default.

This setting should track icon location per pane, per sidebar. So for example, the stored state can look like this:

• Navigator Sidebar
  • panel 1
    • project
    • source control
    • find
  • panel 2
    • debug
    • tasks
    • symbols
• Inspector Sidebar
  • panel 1
    • source control
    • file
    • quick help

Updated #41 with this information.

[austincondiff]

Please also refer to #479 for additional context around what is planned for sidebar split panels.

[austincondiff]

Please address the following items before we can merge:

• The cursor should not turn into a "+" as the user hovers over other items.
• The item being dragged should be fully opaque and the original should be 0% opacity.
• As the user hovers, icons should animate to move out of the way to make room for the dropped item.
• Axis should be locked to the X axis unless the cursor exits the sidebar dock (icon tab bar).

The overall interaction should feel like dragging to reorder tabs in Xcode or Finder.

[austincondiff]

When you are finished, please update the video in the PR description.

[jav-solo]

Please address the following items before we can merge:

• The cursor should not turn into a "+" as the user hovers over other items.
• The item being dragged should be fully opaque and the original should be 0% opacity.
• As the user hovers, icons should animate to move out of the way to make room for the dropped item.
• Axis should be locked to the X axis unless the cursor exits the sidebar dock (icon tab bar).

The overall interaction should feel like dragging to reorder tabs in Xcode or Finder.

It seems to be behaving as desired. Please see videos

[lukepistrol]

Please make sure to also fix the SwiftLint errors. For more information on SwiftLint see this Wiki entry

[lukepistrol]

Quick question: Is the order persistent? Meaning: is it saved to preferences.json?

[jav-solo]

Quick question: Is the order persistent? Meaning: is it saved to preferences.json?

It is not. I mentioned that in issue #41. Realistically, I will not be able to complete that piece at this time.

[lukepistrol]

Quick question: Is the order persistent? Meaning: is it saved to preferences.json?

It is not. I mentioned that in issue #41. Realistically, I will not be able to complete that piece at this time.

No problem 😉 just wanted to know

[lukepistrol]

Code looks fine to me! Once @austincondiff approves we can merge 👍

[austincondiff]

Looks fantastic, great work! 👏

[austincondiff]

@allcontributors add @jav-solo for code

[allcontributors]

@austincondiff

I've put up a pull request to add @jav-solo! 🎉