Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Cannot close account provider select window #931

Closed
lukasmalkmus opened this issue Jan 12, 2023 · 3 comments · Fixed by #980
Closed

🐞 Cannot close account provider select window #931

lukasmalkmus opened this issue Jan 12, 2023 · 3 comments · Fixed by #980
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lukasmalkmus
Copy link

Description

I created a new account but cannot close the window where I can select the type of account I want to add, even after successfully adding an account.

Furthermore, the window where I can add account details is greyed out on the first attempt.

To Reproduce

  1. Go to "Preferences > Accounts"
  2. Click "+"
  3. Select "GitHub"
  4. Observe the account details window being greyed out
  5. Click "Cancel" (continuing to create the account should also work)
  6. Click "Cancel" (on the account select window)
  7. Observe the account select window not going away

Expected behavior

The account select window should go away when clicking "Cancel".

Also the account details window should not be greyed out.

Version information

CodeEdit: 0.0.1
macOS: 13.1
Xcode: 14.2

Additional context

Reporting because I feel like these two issues belong together.

Screen.Recording.2023-01-12.at.11.32.14.mov
@lukasmalkmus lukasmalkmus added the bug Something isn't working label Jan 12, 2023
@austincondiff
Copy link
Collaborator

I can confirm, I’ve experienced this one as well.

@lukepistrol lukepistrol added the good first issue Good for newcomers label Jan 13, 2023
@neil-ptr
Copy link
Contributor

Hi, I'd like to take this issue :)

@lukepistrol
Copy link
Member

@neilZon assigned it to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: 🏁 Complete
Development

Successfully merging a pull request may close this issue.

4 participants