Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Select account provider dialog not closing #980

Merged
merged 1 commit into from
Jan 16, 2023
Merged

fix: Select account provider dialog not closing #980

merged 1 commit into from
Jan 16, 2023

Conversation

neil-ptr
Copy link
Contributor

@neil-ptr neil-ptr commented Jan 16, 2023 •
edited by lukepistrol
Loading

Description

The solution implemented basically does not toggle openAccountDialog off after selecting a git account until after a successful git account login since AccountSelectionDialog holds the state variable (openGitLogin) for openAccountLoginDialog to stay open

Related Issue

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

Note: Pay attention to the top of the recording, this is where I ctrl + up arrow to show that there isn't another account selection dialog hiding behind the preferences window similar to the video in the linked issue

Screen.Recording.2023-01-15.at.7.31.18.PM.mov

@lukepistrol lukepistrol added the bug Something isn't working label Jan 16, 2023
austincondiff
austincondiff approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@austincondiff austincondiff merged commit ca3789c into CodeEditApp:main Jan 16, 2023
@austincondiff
Copy link
Collaborator

@allcontributors add @neilZon for bug

@allcontributors allcontributors bot mentioned this pull request Jan 16, 2023
Merged
@allcontributors
Copy link
Contributor

@austincondiff

I've put up a pull request to add @neilZon! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukepistrol lukepistrol lukepistrol approved these changes

@austincondiff austincondiff austincondiff approved these changes

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

@Wouter01 Wouter01 Awaiting requested review from Wouter01

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Cannot close account provider select window
3 participants
@neil-ptr @austincondiff @lukepistrol