fix: Allow multiple account with same username (#1012) #1013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the
gitProviderLink
as a part of theSourceControlAccounts
's ID, which allows us to easily distinguish accounts having the same username but from different git providers (account types)gitProviderLink
check) because that solution caused other problems like showing the same account multiple times in settings.Check
gitProviderLink
andgitAccountName
instead ofid
before adding a new account. (Otherwise, changes to theid
format will partially brake the old accounts added in earlier versions).Change how the description below
Clone Using
so it won't always showNew repositories will be cloned from **GitHub** using...
.Related Issue
Checklist
Screenshots