Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow multiple account with same username (#1012) #1013

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

Cubik65536
Copy link
Contributor

@Cubik65536 Cubik65536 commented Jan 21, 2023

Description

  • Add the gitProviderLink as a part of the SourceControlAccounts's ID, which allows us to easily distinguish accounts having the same username but from different git providers (account types)

    • P.S.: I did not use the method mentioned in the issue (add a gitProviderLink check) because that solution caused other problems like showing the same account multiple times in settings.
  • Check gitProviderLink and gitAccountName instead of id before adding a new account. (Otherwise, changes to the id format will partially brake the old accounts added in earlier versions).

  • Change how the description below Clone Using so it won't always show New repositories will be cloned from **GitHub** using....

Related Issue

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

image

Allow multiple source control accounts to use same username if they are not using the same provider
This prevent the description from always says `New repositories will be cloned from GitHub using`
This is to prevent changes to the `id` format braking the old accounts added in earlier versions
@Cubik65536 Cubik65536 closed this Jan 21, 2023
@Cubik65536 Cubik65536 reopened this Jan 21, 2023
@Cubik65536
Copy link
Contributor Author

@austincondiff Can you look at this, please? I could not add reviewers when I open Pull Requests, sorry.

@austincondiff austincondiff merged commit 3e9e0db into CodeEditApp:main Jan 23, 2023
@austincondiff
Copy link
Collaborator

@allcontributors add @Cubik65536 for bug

@allcontributors
Copy link
Contributor

@austincondiff

I've put up a pull request to add @Cubik65536! 🎉

@Cubik65536 Cubik65536 deleted the fix-multiple-git-account branch January 23, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants