Addressing features/bugs with the terminal

[bombardier200]

Description

Address bugs and features of the built in terminal
Updated SwiftTerm to point to 1.2.0
Currently added changing the cursor style
Fixed bleeding edge issue

Related Issue

• closes ✨ Terminal Cursor Style, Width, Blinking #789
• closes 🐞 Terminal edges bleed if height is not a multiple of the line height #615
• closes 🐞 Terminal Cursor Lagging #841

Checklist

• I read and understood the contributing guide as well as the code of conduct
• My changes generate no new warnings
• My code builds and runs on my machine
• I documented my code
• Review requested

Screenshots

[iggy890]

Nice job in finding this, just want to comment that it's called caret not carrot, this could cause confusion with future contributors

[austincondiff]

And this whole time I thought we were picking carrots! 😄🥕

[iggy890]

And this whole time I thought we were picking carrots! 😄🥕

Well, I guess we were… 🐰

[lukepistrol]

Just some considerations about a tiny spelling error (🥕) and one line_length violation.

Otherwise great job 😉

[bombardier200]

Thanks for looking, lets just say I was a little tired when I did this lol!

[lukepistrol]

One additional thing I'd like to discuss:

Instead of having a list of all the curser styles like you can see below, just have the main 3 styles (block, underline, bar) and have a separate boolean toggle the blinking behavior instead. This would make selection a lot cleaner IMO.

Any thoughts on this? @austincondiff @Wouter01 @0xWDG @KaiTheRedNinja

[bombardier200]

@lukepistrol I agree with that, that make it look a lot better. We made a discussion post in SwiftTerm to discuss what all options we could actually do with the cursor styles and other terminal related ideas, but this will take some time to develop. See migueldeicaza/SwiftTerm#279 For merging the current changes since there are a few bug fixes, once we decide on the layout we want to go with for settings, I will mark it as ready and implement other changes in another PR.

[austincondiff]

I don’t like the duplication. Blink will eventually be much more than a simple toggle. See the discussion here.

[bombardier200]

@austincondiff so for now would you just recommend leaving it as the picker?

[austincondiff]

If you can, go ahead and add the blink toggle if you can. We can change it to a blink style picker later on.

[bombardier200]

@austincondiff So the picker will be the style(block, underline, bar), and then a toggle for if you want it to blink or not?

[lukepistrol]

@bombardier200 JFYI SwiftTerm now has a new release. Please change the dependency to use exact: 1.2.0.

https://github.com/migueldeicaza/SwiftTerm/releases/tag/1.2.0

[austincondiff]

@bombardier200 Yes, that works great.

[bombardier200]

New preferences view, this PR should be ready to go now!

[lukepistrol]

Looks good! 👍

[austincondiff]

Looks great @bombardier200! 👏

[austincondiff]

@Wouter01 Should we wait for the splitview branch to be merged before merging this PR into main? (No rush, we can wait if we need to.)

[Wouter01]

@Wouter01 Should we wait for the splitview branch to be merged before merging this PR into main?

Nope, all fine!

[Wouter01]

nice work!