Change document types priority #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinix909
pushed a commit
to xinix909/CodeTransfer
that referenced
this pull request
Sep 7, 2024
# Description Tracks indexes that were not given an explicit color and highlights them as normal text. This fixes problems where certain characters would change color (eg: they were put in a comment) and then need to change back, but were skipped. This also fixes the problem in CodeEditApp#99 where text was not given an explicit highlight on paste. [Since `STTextView` does not add default attributes to pasted text by default](https://github.com/krzyzanowskim/STTextView/blob/5d137731401d12412d567244facf086c325ff95b/Sources/STTextView/STTextView%2BCopyPaste.swift#L26) (see the `useTypingAttributes: false` in that method call). Doing this also seems to have an effect on the annoying glitching that was caused when entering text in an empty line (see the comment screen recording) This PR also adds a helper for converting from an `NSRange` to a `Range<Int>` and gets rid of a bunch of ugly force unwraps that existed before. It also adds some convenience methods for modifying `IndexSet`s using indexes from `NSRange` objects. # Related Issues - CodeEditApp#99 # UI Fixes ### Paste Text (Old) https://user-images.githubusercontent.com/35942988/212186310-ee50dcaa-ebec-4e21-905b-562fc2cdf940.mov ### Paste Text (new) https://user-images.githubusercontent.com/35942988/212186342-402ceb89-2122-4431-88ac-2363e6452323.mov ### Multi-Line comment (old) https://user-images.githubusercontent.com/35942988/212186411-dc77744f-270b-4615-80c6-ed02e7c38e80.mov ### Multi-Line comment (new) https://user-images.githubusercontent.com/35942988/212186437-ba014944-fa6c-4de9-8ad3-c8105a655418.mov Closes CodeEditApp#99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110