Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: renaming a file uses the wrong background color #1241

Merged
merged 1 commit into from
Apr 24, 2023
Merged

bugfix: renaming a file uses the wrong background color #1241

merged 1 commit into from
Apr 24, 2023

Conversation

aaryankotharii
Copy link
Member

@aaryankotharii aaryankotharii commented Apr 23, 2023 •
edited
Loading

change the bg color from none to textBackgroundColor

Description

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

before.mov
after.mov

@austincondiff
Copy link
Collaborator

Can you add a before and after screenshot to your PR description?

@aaryankotharii
Copy link
Member Author

Can you add a before and after screenshot to your PR description?

Done 👍

austincondiff
austincondiff approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Good catch!

@matthijseikelenboom matthijseikelenboom merged commit d6a2f30 into CodeEditApp:main Apr 24, 2023
@luah5 luah5 mentioned this pull request Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthijseikelenboom matthijseikelenboom matthijseikelenboom approved these changes

@austincondiff austincondiff austincondiff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaryankotharii @austincondiff @matthijseikelenboom