Finding in workspace #125
Merged
Finding in workspace #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayZhao1998
force-pushed
the
feature/workspace-search
branch
2 times, most recently
from
2abc1c2 to
539c3b0
Compare
RayZhao1998
force-pushed
the
feature/workspace-search
branch
from
539c3b0 to
2bbcdcb
Compare
RayZhao1998
force-pushed
the
feature/workspace-search
branch
from
2bbcdcb to
d994e76
Compare
RayZhao1998
requested review from
austincondiff,
pkasila and
lukepistrol
and removed request for
pkasila
austincondiff
approved these changes
Mar 22, 2022
|
Finding in workspace is a huge functionality. There's still a lot of work to do. I'll file an issue to list remaining work to do tomorrow. |
lukepistrol
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to implement finding in workspace, only matched case.
Current state: