Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #1035 finding in project bug #1268

Merged
merged 1 commit into from
May 29, 2023
Merged

Fix: #1035 finding in project bug #1268

merged 1 commit into from
May 29, 2023

Conversation

RayZhao1998
Copy link
Collaborator

Description

This PR fix #1035:

  • Fix the issue of not displaying any results after a search.
  • Fix the display issue with the count of search results.

By the way, In this PR, I removed the searchId that was previously used to refresh the UI when performing a search with the same text. I think when a search is triggered, the searchResults will update, causing the UI to refresh.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

截屏2023-05-15 00 40 26
2023-05-15.00.43.25.mov

@RayZhao1998
fix: CodeEditApp#1035 finding in project bug
8e73855 
- No results display when finding
- Found results count
@austincondiff austincondiff requested a review from a team May 14, 2023 16:54
austincondiff
austincondiff approved these changes May 14, 2023
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@austincondiff austincondiff requested a review from a team May 16, 2023 16:14
@matthijseikelenboom matthijseikelenboom merged commit 0016e3b into CodeEditApp:main May 29, 2023
@matthijseikelenboom matthijseikelenboom mentioned this pull request May 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthijseikelenboom matthijseikelenboom matthijseikelenboom approved these changes

@austincondiff austincondiff austincondiff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RayZhao1998 @austincondiff @matthijseikelenboom