Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve textfield behavior in Project Navigator #1291

Merged
merged 2 commits into from
Jun 3, 2023
Merged

Improve textfield behavior in Project Navigator #1291

merged 2 commits into from
Jun 3, 2023

Conversation

dscyrescotti
Copy link
Contributor

@dscyrescotti dscyrescotti commented Jun 2, 2023 •
edited
Loading

Description

This PR includes the enhancement of textfield behavior in Project Navigator as follows.

  1. Select filename excluding file extension when focusing textfield
  2. Fix background layer of textfield turning into blue

Related Issues

#1290

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2023-06-02.at.7.28.39.PM.mov

thecoolwinter
thecoolwinter approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@Wouter01 Wouter01 self-requested a review June 2, 2023 23:55
@austincondiff austincondiff merged commit 851dc79 into CodeEditApp:main Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wouter01 Wouter01 Wouter01 approved these changes

@thecoolwinter thecoolwinter thecoolwinter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dscyrescotti @thecoolwinter @Wouter01 @austincondiff