-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative Windowing System #1329
Merged
Wouter01
merged 15 commits into
CodeEditApp:main
from
Wouter01:windowsystem-improvements
Jun 20, 2023
Merged
Alternative Windowing System #1329
Wouter01
merged 15 commits into
CodeEditApp:main
from
Wouter01:windowsystem-improvements
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Wouter01
requested review from
matthijseikelenboom,
austincondiff and
bombardier200
June 18, 2023 17:19
Co-authored-by: Matthijs Eikelenboom <matthijs697@live.nl>
matthijseikelenboom
previously approved these changes
Jun 19, 2023
6 tasks
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
matthijseikelenboom
approved these changes
Jun 20, 2023
0xWDG
approved these changes
Jun 20, 2023
austincondiff
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I might have a few questions about feature flags we may discuss on Discord later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current windowing system is great, but has some limitations. Due to the usage of NSWindow, we cannot fully use the SwiftUI focus system, which is important for the menubar (and possibly later the command palette). It also has some additional problems, such as:
This PR adds an alternative way of handling windows. This fixes above issues and also brings:
Visually, no changes should be visible.
This window handling is experimental so it's put behind a feature flag. The feature flag can be set in settings and is disabled by default. Due to API limitations, the inspector is only visible on macOS Sonoma when the feature flag is enabled.
The feature flag will likely stay put until around the release of macOS Sonoma. Afterwards, we can review what solution would work best. If Apple fixes the focus api in NSWindow (FB12310769), it might be preferable to stick to the existing solution.
Related Issues
Checklist
Screenshots