Update Inspector Sidebar

[thecoolwinter]

Description

• Removed all placeholder UI from the inspector sidebar:
  • The "Quick Help" menu
  • Unused settings and preferences
  • Unused and confusing file type menu with carbon copy Xcode options.
• Filled in features in the file inspector:
  • Added ability to override file language (this PR also updates CETV, so it also incorporates Shebang & Modeline detection)
  • Renaming & Moving files works, and both open the correct tab and update necessary inspector UI to match
• Connect text settings in file inspector to the real settings data structure
  • Created two new views: IndentOptionView and TabWidthOptionView.
  • Both views replace existing UI in Settings and the inspector.
• Make inspector tabs permanent, keeping user selection when no tab is selected.

This PR removes the "Quick Help" menu. Currently, it doesn't perform any function and only serves to confuse users. It can be added back in the future when CodeEdit has some kind of in-app help functionality/user manual.

Related Issues

• closes 🐞 Inspector doesn't populate on file open #1303
• closes 🐞 Inspector sidebar icon position changes when clicking on Quick Help inspector (with tab bar on side) #1270
• closes 🐞 file type isn't identified correctly. Changed manually but it gets reset when closed #1148
• closes 🐞 [0.0.1-alpha.21] Misidentifies CSharp source files as Swift Source files. #1014
• ✨ File Inspector #362
• Incorporates changes that closed 🐞 Detect File Language Via shebang CodeEditLanguages#46

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

Screen.Recording.2023-06-18.at.11.52.28.PM.mov

[Wouter01]

It looks like the syntax highlighting doesn't work when I switch file types. If I switch to another file and go back it seems to work. Is this intended?

Screen.Recording.2023-06-19.at.14.10.13.mov

[thecoolwinter]

Ah this is a CETV bug. I've opened a PR for that on that repository.

[austincondiff]

The file inspector is not meant to change the app Settings but changes these on a per-file basis.

[thecoolwinter]

The file inspector is not meant to change the app Settings but changes these on a per-file basis.

I'll change that 👍

[0xWDG]

LGTM, works well. agree that #1334 (comment) should be done before merging :)

[austincondiff]

A few other things that I might mention before this is merged:

• because it is per-file, this is why it reads "Indent using" instead of "Prefer indent using" as in the app Setting.
• I prefer the widths being grouped together as it was before
• In "Wrap lines to editor width" drop "to editor width" so it simply reads "Wrap lines" like it was before, as it is implied and labels should be short as possible for the inspector
• We should be able to change text encoding and line endings for the file in question, were these removed because they are not yet implemented?

[thecoolwinter]

Yes the encoding options were removed because they haven't been implemented yet. I've made the changes you mentioned. Demo below:

Screen.Recording.2023-06-19.at.11.56.07.PM.mov

[austincondiff]

Looks good! I wonder how the file inspector would go back to following the preferred settings after making a change. I'd imagine setting it back to the preferred setting might do this. I wonder what should happen if I set the preferred setting to match the file inspectors. Any thoughts? (this can wait for another PR)

Also, please resolve the merge conflicts. 🙂 When you do I can approve.

[thecoolwinter]

@austincondiff That's exactly how it works already. If the inspector's setting is set to the same value as the global setting, the override is set to nil. I tried to demo that in my video. Towards the end you can see me change some preferences in the inspector, then change the global settings and the inspector only follows the unmodified ones.

[thecoolwinter]

I'm not seeing any merge conflicts on my side either. I see them now, Github wasn't updating. Updating that now.

[austincondiff]

Nice work @thecoolwinter!