Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Font bugs #1337

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Fixing Font bugs #1337

merged 1 commit into from
Jun 19, 2023

Conversation

bombardier200
Copy link
Contributor

@bombardier200 bombardier200 commented Jun 19, 2023 •
edited
Loading

Description

This PR addresses 2 bugs, one where the top 3 fonts would not update till after clicking on the 2nd font after system default and then also the editor font being 1 font update behind.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2023-06-19.at.11.22.57.AM.mov

0xWDG
0xWDG approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Works well 😊 nice work!

@thecoolwinter thecoolwinter merged commit c345316 into main Jun 19, 2023
@thecoolwinter thecoolwinter deleted the fontFixes branch June 19, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecoolwinter thecoolwinter thecoolwinter approved these changes

@0xWDG 0xWDG 0xWDG approved these changes

@austincondiff austincondiff Awaiting requested review from austincondiff

@Wouter01 Wouter01 Awaiting requested review from Wouter01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Recent 3 fonts does not update after 1st font update 🐞 Font Management is Broken
3 participants
@bombardier200 @0xWDG @thecoolwinter