-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SwiftLint enable attributes
rule
#1339
Merged
austincondiff
merged 9 commits into
CodeEditApp:main
from
0xWDG:swiftlint-attributes-rule
Jun 21, 2023
Merged
SwiftLint enable attributes
rule
#1339
austincondiff
merged 9 commits into
CodeEditApp:main
from
0xWDG:swiftlint-attributes-rule
Jun 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bombardier200
previously approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CodeEdit/Features/InspectorSidebar/Models/FileInspectorModel.swift
Outdated
Show resolved
Hide resolved
matthijseikelenboom
previously approved these changes
Jun 20, 2023
bombardier200
previously approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Wouter01
reviewed
Jun 21, 2023
CodeEdit/Features/InspectorSidebar/Models/FileInspectorModel.swift
Outdated
Show resolved
Hide resolved
0xWDG
dismissed stale reviews from bombardier200 and matthijseikelenboom
via
June 21, 2023 20:28
d44cd83
austincondiff
requested review from
austincondiff,
Wouter01,
matthijseikelenboom and
bombardier200
June 21, 2023 20:29
austincondiff
approved these changes
Jun 21, 2023
matthijseikelenboom
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled SwiftLint
attributes
rule.Description
https://realm.github.io/SwiftLint/attributes.html
Attributes
Attributes should be on their own lines in functions and types, but on the same line as variables and imports
Identifier: attributes
Enabled by default: No
Supports autocorrection: No
Kind: style
Analyzer rule: No
Minimum Swift compiler version: 5.0.0
Default configuration: severity: warning, always_on_same_line: [“@IBAction”, “@NSManaged”], always_on_line_above: []
Related Issues
N/A
Checklist
Screenshots
N/A