Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftLint enable attributes rule #1339

Merged
merged 9 commits into from
Jun 21, 2023

Conversation

0xWDG
Copy link
Collaborator

@0xWDG 0xWDG commented Jun 19, 2023

Enabled SwiftLint attributes rule.

Description

https://realm.github.io/SwiftLint/attributes.html

Attributes

Attributes should be on their own lines in functions and types, but on the same line as variables and imports

Identifier: attributes
Enabled by default: No
Supports autocorrection: No
Kind: style
Analyzer rule: No
Minimum Swift compiler version: 5.0.0
Default configuration: severity: warning, always_on_same_line: [“@IBAction”, “@NSManaged”], always_on_line_above: []

Related Issues

N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other (N/A)
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code (N/A)

Screenshots

N/A

@0xWDG 0xWDG self-assigned this Jun 19, 2023
bombardier200
bombardier200 previously approved these changes Jun 20, 2023
Copy link
Contributor

@bombardier200 bombardier200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xWDG 0xWDG requested a review from bombardier200 June 21, 2023 10:49
bombardier200
bombardier200 previously approved these changes Jun 21, 2023
Copy link
Contributor

@bombardier200 bombardier200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@austincondiff austincondiff merged commit 184e086 into CodeEditApp:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants