Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed closing animation for the tabs #1383

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Removed closing animation for the tabs #1383

merged 1 commit into from
Jul 19, 2023

Conversation

FastestMolasses
Copy link
Member

Description

Removes the animation when closing a file to be like Xcode.

Related Issues

Closes #1073

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

The current animation when closing tabs:
animation

How it looks now:
no-animation

@austincondiff austincondiff requested a review from a team July 18, 2023 02:20
austincondiff
austincondiff approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've been meaning to do that for a while! 😄

thecoolwinter
thecoolwinter approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@thecoolwinter thecoolwinter merged commit 1b5fc2b into CodeEditApp:main Jul 19, 2023
@FastestMolasses FastestMolasses deleted the close-animate branch July 19, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecoolwinter thecoolwinter thecoolwinter approved these changes

@austincondiff austincondiff austincondiff approved these changes

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Tabs animate incorrectly
3 participants
@FastestMolasses @austincondiff @thecoolwinter