feat: creates file/directory in active path

[EstebanBorai]

Description

Uses EditorManager to retrieve active directory and create Files/Directories in the
current active directory.

Related Issues

I found the todos in the source code while reading.
I wanted to address the related issue but didn't found one.

Here is the TODO comment: https://github.com/CodeEditApp/CodeEdit/blob/main/CodeEdit/Features/NavigatorSidebar/ProjectNavigator/ProjectNavigatorToolbarBottom.swift#L59

• #ISSUE_NUMBER

N/A

Checklist

• I read and understood the contributing guide as well as the code of conduct
• [-] The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

Screen.Recording.2023-09-12.at.8.05.30.PM.mov

[matthijseikelenboom]

The TODO comment is in the ProjectNavigator. You're accessing the TabBar to get the required data. While I believe that this does work, but it's not the correct way. We shouldn't want to mix those domains when not necessary. The ProjectNavigator should have a current selected file as well, so that should be accessed. As the ProjectNavigatorBottomBar is part of thé ProjectNavigator.

[EstebanBorai]

The TODO comment is in the ProjectNavigator. You're accessing the TabBar to get the required data. While I believe that this does work, but it's not the correct way. We shouldn't want to mix those domains when not necessary. The ProjectNavigator should have a current selected file as well, so that should be accessed. As the ProjectNavigatorBottomBar is part of thé ProjectNavigator.

Makes sense! Will review!

[thecoolwinter]

Addressing the comment left in Discord: This is very close, instead of using the workspace document, use the editor manager directly via the following in ProjectNavigatorToolbarBottom:

@EnvironmentObject var editorManager: EditorManager

You can use the editor manager to get the active editor pane, and then the selected tab from that. See the EditorManager.activeTabGroup, and Editor.selectedTab properties respectively.

That should get rid of the need to add methods to WorkspaceDocument and addresses the domain concern @matthijseikelenboom had.

[EstebanBorai]

Addressing the comment left in Discord: This is very close, instead of using the workspace document, use the editor manager directly via the following in ProjectNavigatorToolbarBottom:

@EnvironmentObject var editorManager: EditorManager

You can use the editor manager to get the active editor pane, and then the selected tab from that. See the EditorManager.activeTabGroup, and Editor.selectedTab properties respectively.

That should get rid of the need to add methods to WorkspaceDocument and addresses the domain concern @matthijseikelenboom had.

Great! Thanks so much!

[EstebanBorai]

Hi @thecoolwinter I just applied suggestions! Also added a recording for demo. Repo in demo is public available here: https://github.com/whizzes/playa

[thecoolwinter]

Awesome! Looks good to me

[austincondiff]

@EstebanBorai Could we highlight the text after the untitled file/folder is created so the user can simply type their desired name for it?

[austincondiff]

LGTM!

[thecoolwinter]

@matthijseikelenboom can we get a review here

[austincondiff]

@allcontributors add @EstebanBorai for code

[allcontributors]

@austincondiff

I've put up a pull request to add @EstebanBorai! 🎉