-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another search speed up 💨 #1500
Another search speed up 💨 #1500
Conversation
Chnaged `lineNumber` to `rangeWIthinFile` which is a Range<String.Index> instead of a int. Removed `hasKeywordInfo` from `SearchResultMatchmodel`
Do we know why tests are failing?
We just merged @thecoolwinter's new text view, but it should be there. |
It seems like I couldn't locate 'codeeditortextview' version 0.6.8; instead, I found version 0.7.0. However, 'codeeditsourceeditor' did have a release for version 0.6.8. Could there be a mix-up between the two? |
In this PR, I've enhanced the search process by implementing regular expressions. Rather than manually scanning through each line, regX is now employed, significantly boosting the speed and efficiency of locating search results.
Speed comparison(2.0 means this pr):
*speed in seconds. The Flutter app contains a build folder with a manifest.json file that only consists of one large line and a main.dart.js file that contains long and many lines
Checklist
Screenshots