Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another search speed up 💨 #1500

Merged
merged 10 commits into from
Dec 17, 2023

Conversation

tom-ludwig
Copy link
Member

@tom-ludwig tom-ludwig commented Dec 5, 2023

In this PR, I've enhanced the search process by implementing regular expressions. Rather than manually scanning through each line, regX is now employed, significantly boosting the speed and efficiency of locating search results.

Speed ​​comparison(2.0 means this pr):

Search Term Searched Project CE(2.0) CE(main) AE Lines of Code Characters
'struct' CE 0.0139 0.0412 0.1437 29,872 31,012,654
'class' Flutter-App 0.022 0.602 0.783 141,014 180,400,751

*speed in seconds. The Flutter app contains a build folder with a manifest.json file that only consists of one large line and a main.dart.js file that contains long and many lines

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code
  • Fix search preview
  • Refactor evaluateFile function: Split the evaluateFile function into smaller, focused functions, each adhering to the single responsibility principle

Screenshots

@tom-ludwig tom-ludwig marked this pull request as ready for review December 12, 2023 15:06
@austincondiff
Copy link
Collaborator

Do we know why tests are failing?

xcodebuild: error: Could not resolve package dependencies:
  Dependencies could not be resolved because no versions of 'codeedittextview' match the requirement 0.6.[8](https://github.com/CodeEditApp/CodeEdit/actions/runs/7186953012/job/19662455879?pr=1500#step:4:9) and root depends on 'codeedittextview' 0.6.8.

We just merged @thecoolwinter's new text view, but it should be there.

@tom-ludwig
Copy link
Member Author

tom-ludwig commented Dec 15, 2023

Do we know why tests are failing?

xcodebuild: error: Could not resolve package dependencies:
  Dependencies could not be resolved because no versions of 'codeedittextview' match the requirement 0.6.[8](https://github.com/CodeEditApp/CodeEdit/actions/runs/7186953012/job/19662455879?pr=1500#step:4:9) and root depends on 'codeedittextview' 0.6.8.

We just merged @thecoolwinter's new text view, but it should be there.

It seems like I couldn't locate 'codeeditortextview' version 0.6.8; instead, I found version 0.7.0. However, 'codeeditsourceeditor' did have a release for version 0.6.8. Could there be a mix-up between the two?

@austincondiff austincondiff merged commit c276d03 into CodeEditApp:main Dec 17, 2023
2 checks passed
@thecoolwinter thecoolwinter added the enhancement New feature or request label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants