Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated path picker design #1502

Merged
merged 7 commits into from
Dec 22, 2023
Merged

Updated path picker design #1502

merged 7 commits into from
Dec 22, 2023

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Dec 7, 2023

Description

Updated the design of the pathbar and find navigator pickers for improved usability.

  • Updated the chevron divider
  • On hover the chevron divider is replaced with a picker indicator icon and has a subtle background.
  • The Find Navigator was previously opening below the button instead of on top of it. This change fixes that as well.
  • Removed the checkmark from menus.

Related Issues

Checklist

  • Implement updated design in editor path bar
  • Implement updated design in find navigator
  • Fix Find navigator picker bindings
  • Fix menu item icon color when highlighted out of scope
  • Organize files and clean up code

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2023-12-07.at.2.29.17.AM.mov

Top: Xcode
Middle: CodeEdit Before
Bottom: CodeEdit After

@austincondiff
Copy link
Collaborator Author

austincondiff commented Dec 7, 2023

In the pathbar picker, the symbol needs to be white when the menu item is highlighted because the background will be the accent color. I got it working but the problem is when hovering over a folder, then hovering over a sub-menu. The highlighted folder background turns gray and the new menus highlighted items background is blue, The folders icon color is still white though.

image

The folder icon for "src" should be colored again. Compare that to Xcode...

image

Notice the folder icon next to "Configs" is not white.

You can see the code that handles this here. Any idea how to fix this?

@austincondiff
Copy link
Collaborator Author

austincondiff commented Dec 7, 2023

Another issue I've been seeing is when I click the first popup button after first launch, it hangs, then after a second or two I see this in my console when it resumes.

IMKInputSession (deactivate) timed out waiting for response
Screen.Recording.2023-12-07.at.2.12.09.PM.mov

You don't see in the video each time, but my cursor turns into a rainbow wheel when it hangs.

@austincondiff austincondiff added the help wanted Extra attention is needed label Dec 7, 2023
@austincondiff austincondiff self-assigned this Dec 7, 2023
@austincondiff austincondiff removed the help wanted Extra attention is needed label Dec 16, 2023
@austincondiff
Copy link
Collaborator Author

austincondiff commented Dec 16, 2023

The hanging issue is gone due to @thecoolwinter's new text view. I also removed the highlight logic for now. Ready to review!

@austincondiff
Copy link
Collaborator Author

Can I get a review for this one?

0xWDG
0xWDG previously approved these changes Dec 21, 2023
@austincondiff austincondiff merged commit e57e538 into main Dec 22, 2023
2 checks passed
@austincondiff austincondiff deleted the path-picker branch December 22, 2023 19:37
@thecoolwinter thecoolwinter added the enhancement New feature or request label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants