-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated path picker design #1502
Conversation
In the pathbar picker, the symbol needs to be white when the menu item is highlighted because the background will be the accent color. I got it working but the problem is when hovering over a folder, then hovering over a sub-menu. The highlighted folder background turns gray and the new menus highlighted items background is blue, The folders icon color is still white though. The folder icon for "src" should be colored again. Compare that to Xcode... Notice the folder icon next to "Configs" is not white. You can see the code that handles this here. Any idea how to fix this? |
Another issue I've been seeing is when I click the first popup button after first launch, it hangs, then after a second or two I see this in my console when it resumes.
Screen.Recording.2023-12-07.at.2.12.09.PM.movYou don't see in the video each time, but my cursor turns into a rainbow wheel when it hangs. |
…color when something else is selected.
4506ea5
to
fc7bd9c
Compare
The hanging issue is gone due to @thecoolwinter's new text view. I also removed the highlight logic for now. Ready to review! |
Can I get a review for this one? |
CodeEdit/Features/Editor/PathBar/Views/EditorPathBarComponent.swift
Outdated
Show resolved
Hide resolved
…um duration of zero.
Description
Updated the design of the pathbar and find navigator pickers for improved usability.
Related Issues
Checklist
Fix menu item icon color when highlightedout of scopeScreenshots
Screen.Recording.2023-12-07.at.2.29.17.AM.mov
Top: Xcode
Middle: CodeEdit Before
Bottom: CodeEdit After