Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Xcode themes #1566

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Updated Xcode themes #1566

merged 1 commit into from
Jan 18, 2024

Conversation

armartinez
Copy link
Contributor

@armartinez armartinez commented Jan 17, 2024 •
edited
Loading

Description

Updated the Xcode themes' hex values to the equivalent GenericRGB colors used by default by Xcode.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Before

Screenshot 2024-01-16 at 13 10 15

After

Screenshot 2024-01-16 at 13 10 15

@armartinez
Updated Xcode themes
34bc1ec 
Updated the Xcode themes' hex values to the equivalent GenericRGB colors used by default by Xcode.
@armartinez armartinez mentioned this pull request Jan 17, 2024
Closed
austincondiff
austincondiff approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@austincondiff austincondiff merged commit 0f60059 into CodeEditApp:main Jan 18, 2024
2 checks passed
@austincondiff
Copy link
Collaborator

@allcontributors add @armartinez for bug

@allcontributors allcontributors bot mentioned this pull request Jan 18, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@austincondiff

I've put up a pull request to add @armartinez! 🎉

@armartinez armartinez deleted the updated-xcode-themes branch January 18, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EstebanBorai EstebanBorai EstebanBorai approved these changes

@austincondiff austincondiff austincondiff approved these changes

@0xWDG 0xWDG Awaiting requested review from 0xWDG

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armartinez @austincondiff @EstebanBorai