Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Commands For All Windows, Fix ⌘W #1587

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

thecoolwinter
Copy link
Collaborator

Description

  • Fixes the ⌘W command, it was removed from all windows previously but the PR fixing it only added it to the workspace window. This PR ensures the command works for all windows.
  • Correctly lists window shortcuts (like the welcome window (⌘⇧1) in the windows menu.
  • Removes the settings window from the window shortcuts as it's already listed in the correct spot under the main menu.

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

windowcommands2.mov

Window menu before
Screenshot 2024-02-06 at 1 03 34 AM

Window menu after

Screenshot 2024-02-06 at 1 02 56 AM

@thecoolwinter thecoolwinter merged commit bc5aff9 into CodeEditApp:main Feb 8, 2024
2 checks passed
@thecoolwinter thecoolwinter added the bug Something isn't working label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants