Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: maximized button color issue #1607

Merged
merged 6 commits into from
Mar 9, 2024
Merged

fix: maximized button color issue #1607

merged 6 commits into from
Mar 9, 2024

Conversation

phlpsong
Copy link
Contributor

@phlpsong phlpsong commented Mar 9, 2024

Description

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

before:

Screenshot 2024-03-09 at 22 01 19

after:

Screenshot 2024-03-09 at 22 15 31

dark theme

Screenshot 2024-03-09 at 22 16 12

light theme

austincondiff
austincondiff requested changes Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! It looks good and it does work, however I'd recommend a slightly different approach so we don't need a new ButtonStyle. See my comments for recommended changes. Thanks for your contribution!

CodeEdit/Features/UtilityArea/Views/UtilityAreaView.swift Outdated Show resolved Hide resolved
CodeEdit/Features/UtilityArea/Views/UtilityAreaView.swift Outdated Show resolved Hide resolved
CodeEdit/Features/UtilityArea/Views/UtilityAreaView.swift Outdated Show resolved Hide resolved
phlpsong and others added 4 commits March 9, 2024 22:49
@phlpsong @austincondiff
Update CodeEdit/Features/UtilityArea/Views/UtilityAreaView.swift
3514212 
Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
@phlpsong @austincondiff
Update CodeEdit/Features/UtilityArea/Views/UtilityAreaView.swift
2600a13 
Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
@phlpsong @austincondiff
Update CodeEdit/Features/UtilityArea/Views/UtilityAreaView.swift
20479c8 
Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
@phlpsong
fix: remove unused code
62c8e66
@phlpsong
Copy link
Contributor Author

phlpsong commented Mar 9, 2024

Screenshot 2024-03-09 at 22 51 33

Thanks for your comments, looks better now.

austincondiff
austincondiff previously approved these changes Mar 9, 2024
View reviewed changes
@austincondiff austincondiff self-requested a review March 9, 2024 15:08
tom-ludwig
tom-ludwig approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end.

CodeEdit/Features/UtilityArea/Views/UtilityAreaView.swift Show resolved Hide resolved
@austincondiff austincondiff merged commit b92a3a0 into CodeEditApp:main Mar 9, 2024
2 checks passed
@phlpsong phlpsong deleted the maximized-button branch March 12, 2024 01:59
@thecoolwinter thecoolwinter added the bug Something isn't working label Mar 12, 2024
FastestMolasses pushed a commit to Angelk90/CodeEdit that referenced this pull request Apr 11, 2024
@phlpsong @austincondiff @FastestMolasses
fix: maximized button color issue (CodeEditApp#1607)
b86197d 
* fix: maximized button color issue

* Update CodeEdit/Features/UtilityArea/Views/UtilityAreaView.swift

Co-authored-by: Austin Condiff <austin.condiff@gmail.com>

* Update CodeEdit/Features/UtilityArea/Views/UtilityAreaView.swift

Co-authored-by: Austin Condiff <austin.condiff@gmail.com>

* Update CodeEdit/Features/UtilityArea/Views/UtilityAreaView.swift

Co-authored-by: Austin Condiff <austin.condiff@gmail.com>

* fix: remove unused code

* fix: remove duplicate modifiers in icon style

---------

Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

@tom-ludwig tom-ludwig tom-ludwig approved these changes

@0xWDG 0xWDG 0xWDG approved these changes

@FastestMolasses FastestMolasses Awaiting requested review from FastestMolasses

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phlpsong @austincondiff @0xWDG @tom-ludwig @thecoolwinter