Rename OverlayPanel and OverlayView classes #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austincondiff
requested review from
austincondiff,
matthijseikelenboom,
FastestMolasses and
tom-ludwig
FastestMolasses
approved these changes
Mar 27, 2024
austincondiff
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Looks good to me! 👍
If you are interested, #1650 is a pretty close change to this one. Thank you for the contribution!
|
@allcontributors add @DanKlaver15 for code |
|
I've put up a pull request to add @DanKlaver15! 🎉 |
|
@austincondiff Sure, I can take #1650 |
|
Awesome! Please comment on the issue so I can assign it to you. |
FastestMolasses
pushed a commit
to Angelk90/CodeEdit
that referenced
this pull request
Apr 11, 2024
* Renamed the OverlayPanel class to SearchPanel * Renamed the OverlayView class to SearchPanelView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The OverlayPanel class was renamed to SearchPanel and the OverlayView class was renamed to SearchPanelView. This was done to keep naming conventions consistent with Xcode.
Related Issues
Checklist