-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All recent projects searchable in Spotlight #1680
Conversation
Looking at this again, there's a few issues with this code being tied to the UI. Because this is in the Due to these reasons, I think this feature might be a good candidate for creating a service. VSCode has this in a |
I tested and the indexing happens whenever you open the app, even if the welcome window is not opened |
All the window views here are initialized at the start of the application. One of the problems is that it only happens once, even if we open new projects, windows, etc. If the indexing fails, then it wont ever be retried. This code in general shouldnt be tied to the welcome window either. For this PR, I'd say it's fine until we get our services defined more, but I'd like to come back to this and move the code into a service to address these issues. |
Got it, thanks. I'll make those changes. |
@FastestMolasses I implemented the requested changes, please let me know if there's anything else you want me to change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements!
Description
All recent projects are now fully indexed and searchable in Spotlight. Indexing happens once when a new window is opened to check if recent projects have changed.
Related Issues
Checklist
Screenshots