fix: distinguish between Move to Trash and Delete Immediately when right clicking a file or folder. #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght clicking a file or folder
|
Excellent work @plbstl! Reviewing this now. |
austincondiff
requested review from
thecoolwinter,
tom-ludwig,
austincondiff and
FastestMolasses
FastestMolasses
requested changes
Apr 30, 2024
CodeEdit/Features/CEWorkspace/Models/CEWorkspaceFileManager+FileManagement.swift
Outdated
Show resolved
Hide resolved
|
@FastestMolasses could you rereview this? There's an issue I want to work on that would conflict with this PR |
FastestMolasses
approved these changes
May 1, 2024
thecoolwinter
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basically what the PR title says.
This PR fixes the issue when deleting a file is not as predictable.
Right click a file or folder to see Move to Trash, and this moves the file or folder to trash.
Holding Option while the context menu is open will change the option to "Delete Immediately...", which deletes the file or folder immediately.
Related Issues
closes #1693
Checklist
Screenshots
Before:
code-edit.bug.move.to.trash.mov
After:
code-edit.fix.move.to.trash.mov