Only Save Workspace Settings If Necessary #1702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I personally dislike unnecessary folders being saved on my computer. This PR adds a check to workspace settings to see if there's any changed settings that need to be saved. If not, it doesn't create the
.codeedit
folder or thesettings.json
file inside it. I've also moved the folder creating logic into thesavePreferences
method to keep that all in the one method.Related Issues
N/A
Checklist
Screenshots