Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Save Workspace Settings If Necessary #1702

Merged
merged 1 commit into from
May 7, 2024

Conversation

thecoolwinter
Copy link
Collaborator

Description

I personally dislike unnecessary folders being saved on my computer. This PR adds a check to workspace settings to see if there's any changed settings that need to be saved. If not, it doesn't create the .codeedit folder or the settings.json file inside it. I've also moved the folder creating logic into the savePreferences method to keep that all in the one method.

Related Issues

N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

@austincondiff austincondiff self-requested a review May 7, 2024 12:55
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austincondiff austincondiff merged commit 54e0726 into CodeEditApp:main May 7, 2024
2 checks passed
@thecoolwinter thecoolwinter added the enhancement New feature or request label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants