Correctly view non-text files in single file window and Open Quickly #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `dismantleNSView` in `AnyFileView` to prevent crashes when using Open Quickly. What crashes? 1. When using Open Quickly without the workaround in `AnyFileView`, search for a media file (.png, .gif, .mp4, etc) 2. Press escape to close Open Quickly 3. re-open Open Quickly. The media preview is gone 4. Attempt to navigate upwards or downwards using the arrow buttons 5. A crash occurs (QuickLook is attempting to reuse an already closed preview)
6 tasks
CodeEdit/Features/Documents/Controllers/CodeEditWindowController.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/StatusBar/ViewModifiers/UpdateStatusBarInfo.swift
Outdated
Show resolved
Hide resolved
…en an editorManager or statusBarViewModel is unavailable
This also prevents Open Quickly previews from updating the status bar
editorManager and statusBarViewModel environment objects are not used in Open Quickly anymore
|
Could you please include a screenshot or screen recording demonstrating this functionality? |
allow files with a utType that is neither image nor PDF to be previewed (CodeEditApp#1822)
|
I've updated the PR description with the visuals for before and after changes. |
…ix-quicklook-single-file-window-and-open-quickly
|
This gets shown in the issues tab when the main branch was merged in. This also happens in the main branch
Perhaps, a simple let frameHeight = constrainedHeight - totalFontHeight + 1
.frame(height: frameHeight >= 0 ? frameHeight : 0) |
|
Or you could use .frame(height: min(0, constrainedHeight - totalFontHeight + 1)) |
thecoolwinter
approved these changes
Aug 21, 2024
thecoolwinter
requested review from
austincondiff,
bombardier200 and
tom-ludwig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends CodeEdit's preview functionality to files viewed in single file window and Open Quickly.
Related Issues
Checklist
Screenshots
BEFORE:
before-open.quickly.mov
AFTER:
after-sfm.gif.mov
after-open.quickly.mov