-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed terminal resize and scroll layout issues, improved utility area toggle animation #1845
Fixed terminal resize and scroll layout issues, improved utility area toggle animation #1845
Conversation
…l. Removed the maximize drawer button in favor of simply dragging to resize up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one little thing, and it’s good to go!
Co-authored-by: Tom Ludwig <tommludwig@icloud.com>
It might be nice to fix the terminal to the top (how it was before) if the scroll position is at the very top. This way the terminal contents are both aligned to the top and when the utility area drawer is resized, the terminal content follows it smoothly. I am not sure how to grab the terminal scroll position we'd need in order to do this though. |
Description
When the terminal was resized, it displayed partial lines at the bottom due to a remainder in the line height multiple. This caused two things:
The terminal height must now be a multiple of a single line’s height to resolve these issues.
Utility area drawer now has a push/pull animation rather than a reveal.
Checklist
Screenshots
Before
codeedit-terminal-height-fix-before-resize-scroll.mov
codeedit-terminal-height-fix-before-resize.mov
After
codeedit-terminal-height-fix-after.mov
VS Code handles this in a similar way
vscode-terminal-height-resize.mov
Improved utility area animation
Screen.Recording.2024-08-10.at.12.44.40.AM.mov
Note
I removed the maximize drawer toggle in favor of simply dragging to resize up. This simplifies things greatly.