Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Monochrome Setting Crash #1873

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix Monochrome Setting Crash #1873

merged 1 commit into from
Sep 5, 2024

Conversation

thecoolwinter
Copy link
Collaborator

Description

Fixes a crash with the monochrome setting. The icon color value's willSet was being called before outlineView was set up, causing an unexpected nil exception. This adds an optional to the call so it's safe to call now.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinter thecoolwinter merged commit 8accb3b into CodeEditApp:main Sep 5, 2024
2 checks passed
@thecoolwinter thecoolwinter added the bug Something isn't working label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xWDG 0xWDG 0xWDG approved these changes

@austincondiff austincondiff austincondiff approved these changes

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@tom-ludwig tom-ludwig Awaiting requested review from tom-ludwig

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Changing folders to monochrome causes app to crash on restart
3 participants
@thecoolwinter @austincondiff @0xWDG