-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project navigator file filtering #1896
Project navigator file filtering #1896
Conversation
Wow this looks awesome! I should have time to review very soon. Excited for this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incredible work @LeonardoLarranaga! Two quick UI-related tweaks:
- When "No Filter Results" appears as a result of not having any results, we should hide the root folder as well.
- When filter text is present and if matches are found amongst files and/or folders, bolded text should have a primary label color and unbolded text should have a secondary label color. If parent folders are shown but do not have a match, than the unbolded text has a primary color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of quick changes.
CodeEdit/Features/Documents/WorkspaceDocument/WorkspaceDocument.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/NavigatorArea/OutlineView/StandardTableViewCell.swift
Outdated
Show resolved
Hide resolved
...Area/ProjectNavigator/OutlineView/ProjectNavigatorViewController+NSOutlineViewDelegate.swift
Outdated
Show resolved
Hide resolved
...dit/Features/NavigatorArea/ProjectNavigator/OutlineView/ProjectNavigatorViewController.swift
Show resolved
Hide resolved
CodeEdit/Features/NavigatorArea/OutlineView/FileSystemTableViewCell.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/NavigatorArea/OutlineView/FileSystemTableViewCell.swift
Outdated
Show resolved
Hide resolved
…wCell.swift Co-authored-by: Khan Winter <35942988+thecoolwinter@users.noreply.github.com>
- Changed `workspace.filter` to `workspace.navigatorFilter` and added its respective comment. - Returned `StandardTableViewCell` to a weak reference of the workspace object. - Replaced the navigators own filter string with the workspace one and added throttle to the filter change. - When closing the window, if there is a search going on, all the items don't get saved expanded anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Description
This pull request adds the ability to search files and folders in the navigator area. The following features were added:
Related Issues
Checklist
Screenshots
(From description list)
Screen.Recording.2024-10-03.at.02.52.30.mov
Screen.Recording.2024-10-03.at.02.53.06.mov
Screen.Recording.2024-10-03.at.02.54.05.mov
Screen.Recording.2024-10-03.at.02.55.53.mov