Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Recently Opened Menu #1919

Merged
merged 8 commits into from
Nov 9, 2024

Conversation

thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented Oct 24, 2024

Description

  • Fixes the recently opened submenu
  • Moves the recently opened logic to it's own space.
  • Limits the recently opened list to 100 items.
  • Syncs AppKit's recent list with ours, keeping the dock menu and other lists up-to-date.

There's been some discussion for the design here. I think after a lot of discussion, this design keeps a lot of what everyone wanted. Not too much information, and information is not hidden behind the option key when it's useful. In my version, we show the path if there's duplicates and show all paths if the option key is pressed.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-11-08.at.11.31.57.AM.mov

@thecoolwinter thecoolwinter marked this pull request as ready for review November 8, 2024 17:46
@thecoolwinter thecoolwinter changed the title Fix Recently Opened Update Recently Opened Nov 8, 2024
@thecoolwinter thecoolwinter changed the title Update Recently Opened Update Recently Opened Menu Nov 8, 2024
@thecoolwinter thecoolwinter added the bug Something isn't working label Nov 8, 2024
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@tom-ludwig tom-ludwig merged commit adf6fa7 into CodeEditApp:main Nov 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Display recents and currently opened items in Dock menu 🐞 Open Recent menu is always empty
3 participants