Deleting a file in the Workspace UI now closes the tab #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work, thanks for fixing this! Can you confirm that tabs are closed in a second editor by clicking here... 
...and opening the tab in the second editor. Then open another file in the first editor and delete the file in the second editor. I just want to make sure that it is closing even when the editor is not in focus. Also, do both tabs close if the same file is open in both editors? |
matthijseikelenboom
approved these changes
Nov 17, 2024
austincondiff
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deleting a file in the Workspace UI now closes the tab.
Related Issues
Checklist
Screenshots
Screen.Recording.2024-11-14.at.10.51.47.mov