Skip to content

Fix Getting Stuck in Sub-View within Settings #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

Kihron
Copy link
Contributor

@Kihron Kihron commented Dec 3, 2024

Description

This is an initial attempt at resolving the below issue. There are a few things of note here before this can be merged. The first is that the introduction of a NavigationStack within individual tab views inadvertently causes the sidebar toggle to remain visible on versions of macOS 13 and below. I have addressed this issue in macOS 14+ by using the new toolbar remove API. The other thing is that I have only fixed this in one area thus far, inside account settings. I did not make a universal solution yet as I wanted to get feedback as to how we would handle this. Ideally, we would have an automatic way to handle subviews.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-12-03.at.1.18.32.PM.mov

Sorry, something went wrong.

@austincondiff
Copy link
Collaborator

@Kihron is this PR ready for review? Is there something you had yet to get done?

@Kihron
Copy link
Contributor Author

Kihron commented Mar 5, 2025

I have been pretty busy recently and haven't had the opportunity to work on this. I'll revisit it in a day or so to hopefully get this finished

@Kihron Kihron force-pushed the design/settings-rework branch from 23fa5c5 to b76a71d Compare May 3, 2025 19:55
@Kihron Kihron closed this May 3, 2025
@Kihron Kihron force-pushed the design/settings-rework branch from b76a71d to dabc17b Compare May 3, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Stuck in Settings, Sub-View. Only way back is via NavigationStack Chain (< Back).
2 participants