Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Control Navigator: Added support for viewing file changes #627

Merged
merged 2 commits into from
May 21, 2022

Conversation

nanashili
Copy link
Contributor

Description

Added support for showing changed/created files in the currently opened workspace.

Related Issue

✨ Source Control Navigator #352

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

Screenshot 2022-05-05 at 14 02 00

0xWDG
0xWDG previously approved these changes May 20, 2022
@lilingxi01
Copy link
Member

Just to confirm: for now, we are not able to view the exact changes in the editor, right?

@austincondiff
Copy link
Collaborator

austincondiff commented May 20, 2022

@lilingxi01 I believe we won't be able to until we get our new editor view in place. @lukepistrol can you confirm?

At that point we will be able to add in features like code review to compare local changes.

@nanashili
Copy link
Contributor Author

@lilingxi01 @austincondiff who are we waiting on?

@austincondiff
Copy link
Collaborator

@nanashili: We are waiting on either @lilingxi01 or @MysteryCoder456 to approve.

Copy link
Contributor

@MysteryCoder456 MysteryCoder456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lilingxi01 lilingxi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nanashili
Copy link
Contributor Author

@austincondiff

@austincondiff austincondiff merged commit 2305fe9 into CodeEditApp:main May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants