Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a few bugs with #247 and converts it to use tree-sitter rather than a regex-based implementation. This should be faster on larger documents and makes it more robust to edge cases in tag regexes. This also handles newlines correctly, as the old PR caused the editor to no longer be able to delete newlines
Also fixes a small bug in the
TreeSitterClient
that caused every query to be dispatched to main asynchronously. This was the cause for a few visual oddities like flashing colors when changing themes. This also improves highlighting while scrolling fast as most highlights are processed synchronously.NewlineProcessingFilter
TagFilter
TreeSitterClient
for synchronously querying the tree sitter tree.TreeSitterClientExecutor
class that the client uses to execute operations safely asynchronously and synchronously.dispatchMain
to see if the thread is already the main thread (meaning no async dispatch)Related Issues
Checklist
Screenshots
Screen.Recording.2024-05-29.at.7.11.15.PM.mov
Screen.Recording.2024-05-29.at.7.37.02.PM.mov