Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally Use System Cursor #21

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

thecoolwinter
Copy link
Contributor

@thecoolwinter thecoolwinter commented Feb 9, 2024

Description

Adds the ability to use the system cursor if available and enabled using a useSystemCursor variable on either TextView or TextSelectionManager.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Example usage in CodeEditSourceEditor:

Screen.Recording.2024-02-20.at.7.01.25.PM.mov

@thecoolwinter thecoolwinter marked this pull request as draft February 9, 2024 22:50
@thecoolwinter thecoolwinter marked this pull request as ready for review February 13, 2024 14:21
@thecoolwinter thecoolwinter marked this pull request as draft February 13, 2024 17:18
@thecoolwinter
Copy link
Contributor Author

This is nearly done. Right now the only issue is when scrolling the view flickers as its frame is updated. It's also missing a few features that are described by Apple to implement for the system cursor.

Copy link
Contributor

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! In the future we may want to make the insertion point color configurable (accent color, text color, or custom).

@thecoolwinter thecoolwinter merged commit 6653c21 into CodeEditApp:main Feb 21, 2024
2 checks passed
@thecoolwinter thecoolwinter deleted the feat/system-cursor branch February 21, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ macOS Sonoma Cursor
2 participants