Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazier Layout, Cursor Height, First & Last Line Selections #30

Merged
merged 2 commits into from
May 16, 2024

Conversation

thecoolwinter
Copy link
Contributor

Description

This is a fairly varied PR, most issues solved here don't have a related issue.

  • Made line layout lazily iterate through lines. This solves:
    • Fixes a edge layout bug where lines that were not previously in the viewport aren't updated during layout. This is related to a CESE bug and is required to fix it.
    • Begins work to make minified files work w/o crashing.
  • Updated the vertical selection destination to move to the beginning/end of the line if moving up/down on the first/last line.
  • Made updating the textview's font cause a layout pass.
  • Added docs for some public methods.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Vertical selection changes:

Screen.Recording.2024-05-11.at.12.15.17.PM.mov

@thecoolwinter thecoolwinter merged commit e421af2 into CodeEditApp:main May 16, 2024
2 checks passed
@thecoolwinter thecoolwinter deleted the lazy-layout branch May 16, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants