Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift-Click to Extend Selection #45

Merged

Conversation

thecoolwinter
Copy link
Contributor

Description

  • Adds the shift-click interaction to extend selections to a clicked point.
  • Adds a convenient NSRange initializer.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-08-20.at.10.44.12.PM.mov

@austincondiff
Copy link
Contributor

austincondiff commented Aug 21, 2024

Oh how interesting. I saw you're screen recording and thought that was incorrect behavior because it didn't pivot the selection range (how this works in VS Code) but rather extended the range. But then I tested in Xcode and it works just as you did it.

I am definitely going to approve but I wonder if we introduce a setting to change this behavior.

Also, check out how this works in TextEdit... I really don't care for it. It is kind of like a hybrid between the two. Very strange.

Copy link
Contributor

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@thecoolwinter thecoolwinter merged commit 2619cb9 into CodeEditApp:main Aug 21, 2024
2 checks passed
@thecoolwinter thecoolwinter deleted the feat/shift-click-extend-selection branch August 21, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Shift-Click Does Not Extend Selection
3 participants