[Misc] Footer: remove Join Us! highlight and all button links underline on hover

[nam-m]

I removed the highlight className from Join Us! button and made all button text-decoration: none on hover in the footer

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
codeforbc-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 28, 2024 0:04am

[CorreyL]

Did a quick test locally, and yeah hover over the links no longer renders an underline, and that doesn't seem to be a desired effect in the Figma, so this looks good to me!

I wanted to note that I committed 1bf8926 because I noticed originally the className of footer__button--highlight was removed in the first commit, but then checking the Figma design, it looks like the Join Us link should be distinctly rendered:

So my commit addresses this, I will let someone else review this PR since I have a code change in now too

@Unknown-0perator do you mind reviewing and approving this PR?

[Unknown-0perator]

@CorreyL, I agree, but I just want to confirm with @SherryW14. If it is not the hover state, it would be better to remove lines 73 to 75

[nam-m]

Thanks @CorreyL and @Unknown-0perator for looking at it.
I felt the Join Us button shouldn't be different from other footer buttons, hence the change. Let's wait for Sherry to check it then!

[Unknown-0perator]

Please remove lines 73 to 75 (Sherry's comment) from #35 (comment); we don't need the hover state. Also, change "About" to "Get Engaged!"

Thanks!

[CorreyL]

Please remove lines 73 to 75 (Sherry's comment) from #35 (comment); we don't need the hover state.

Hover selector removed in e7f8496

Also, change "About" to "Get Engaged!"

Are we certain that About is meant to be turned into Get Engaged!? It seems to me that About should actually be replaced by Code of Conduct (when that page is ready)

I replaced Join Us! with Get Engaged! in 8c17a8e after double checking Sherry's comment in #35, but please let me know if it should actually link to /about

[Unknown-0perator]

Thank you @CorreyL, you are right it is Join Us not About