[Feature] Team profile filter & Team profile card #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unknown-0perator
requested review from
CorreyL,
immangat,
nam-m and
SamHuo213
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CorreyL
requested changes
Jul 7, 2024
There was a problem hiding this comment.
Functionally this looks good! Just a couple spots where I noticed we could reduce the risk of code not being changed in several places, which result in unexpected bugs, and instead consolidating them by referencing existing variables, or creating a variable, ultimately to reduce the use of the same literal across various places in the code.
Co-authored-by: Correy Lim <correylim@gmail.com>
Co-authored-by: Correy Lim <correylim@gmail.com>
Co-authored-by: Correy Lim <correylim@gmail.com>
Co-authored-by: Correy Lim <correylim@gmail.com>
CorreyL
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #34 and issue #33.
As per the discussion I had with Sherry and Chloe, the implementation will exclude the bio section for now.
