Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli #170

Merged
merged 1 commit into from
Mar 21, 2020
Merged

Add cli #170

merged 1 commit into from
Mar 21, 2020

Conversation

jlubken
Copy link
Collaborator

@jlubken jlubken commented Mar 21, 2020

Very small changes to models.py. So merging something else before this is just fine.

FIXME: Add a test to validate the dataframes produced --not the csvs--.

Obviously we want to rework the defaults.py at some point to incorporate:

  • the settings.cfg instead of the settting.py
  • maybe move the settings.cfg parser into classmethods of defaults.py
  • the bounds validation that is duplicated between the cli argument parser and the ui widgets
  • possibly make the Defaults/Constants object own the ranges and help text
  • note that (like the settings.py) the rates in the settings file are not the percents in the ui, so the validation help text and messages are different

And later duplication once refactoring the models with dataframes and running models from the Parameters object:

  • how sim_sir and the utils are run by both the cli and the app

And if we want to output graphs:

  • we do need the max_y_axis added as required to the config file, defaults, parameters
  • haven't looked into the plotting to file dependencies

Closes #171

@jlubken jlubken added the python label Mar 21, 2020
@jlubken jlubken requested a review from quinn-dougherty March 21, 2020 16:03
@jlubken jlubken self-assigned this Mar 21, 2020
Copy link
Collaborator

@quinn-dougherty quinn-dougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, thanks!

@quinn-dougherty quinn-dougherty merged commit 03753c6 into develop Mar 21, 2020
@quinn-dougherty quinn-dougherty deleted the add_cli branch March 21, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cli
2 participants