Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cli execution #200

Merged
merged 3 commits into from
Mar 23, 2020
Merged

Fix cli execution #200

merged 3 commits into from
Mar 23, 2020

Conversation

PhilMiller
Copy link
Collaborator

@PhilMiller PhilMiller commented Mar 23, 2020 •
edited
Loading

Fixes: #198

@PhilMiller
Copy link
Collaborator Author

More fixes coming - code had apparently bit-rotted

@PhilMiller PhilMiller changed the title Fix import error Fix cli execution Mar 23, 2020
@quinn-dougherty
Copy link
Collaborator

this makes basic sense and it's small so i'm gonna trust you on it--- I'll ping Jason on slack about developign some CLI tests.

@quinn-dougherty quinn-dougherty merged commit 458fe52 into CodeForPhilly:develop Mar 23, 2020
@PhilMiller
Copy link
Collaborator Author

Thanks. I was actually using it to test my work on #187, so I can at least confirm that it no longer crashes, and outputs about what I expect now.

@PhilMiller PhilMiller deleted the 198-cli branch March 23, 2020 19:52
@chrowe
Copy link

chrowe commented Mar 23, 2020

I am able to run python cli.py --file ./settings.cfg as of 03753c6

Is this something that would have broken since then?

@PhilMiller PhilMiller mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinn-dougherty quinn-dougherty quinn-dougherty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli.py fails to run
3 participants
@PhilMiller @quinn-dougherty @chrowe