Move computation #208
Merged
Move computation #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #108 ? |
|
Yes except for the dispositions dict. Close 108 if you want. |
quinn-dougherty
approved these changes
Mar 23, 2020
|
does this fix #211 ? |
no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all computation into models.py SimSirModel.
Most properties of Parameters have moved to the SimSirModel.
Replace vectors with raw df from sim_sir_df.
Use column names from sim_sir_df.
Use column names from dispositions dictionary in a way that allows dispositions to be extended beyond 'hospitalized', 'icu', 'ventilated' in model.
Closes #195 Closes #108