Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply Content-Length header when missing #175

Merged
merged 3 commits into from
Aug 17, 2018
Merged

fix: apply Content-Length header when missing #175

merged 3 commits into from
Aug 17, 2018

Conversation

brettstack
Copy link
Collaborator

Please ensure all pull requests are made against the develop branch.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

brettstack and others added 3 commits August 16, 2018 16:12
@brettstack @semantic-release-bot
fix: apply Content-Length header when missing
b0927b8 
* Certain requests (e.g. GET and DELETE) would fail when they included a body due to missing content-length header. See #147, #106, #130
@semantic-release-bot
test: add test for resolutionMode with fresh server
790e976
@semantic-release-bot
test: fix test for Node.js 4
6eb8ad9
@brettstack brettstack changed the base branch from master to develop August 17, 2018 19:37
@brettstack brettstack requested a review from keetonian August 17, 2018 21:26
@brettstack brettstack mentioned this pull request Aug 17, 2018
Closed
@brettstack brettstack merged commit c2f416b into develop Aug 17, 2018
brettstack pushed a commit that referenced this pull request Aug 20, 2018
@semantic-release-bot
chore(release): version 3.3.5 [skip ci]
5f61b40 
<a name="3.3.5"></a>
## [3.3.5](v3.3.4...v3.3.5) (2018-08-20)

### Bug Fixes

* apply Content-Length header when missing ([b0927b8](b0927b8)), closes [#147](#147) [#106](#106) [#130](#130)
* apply Content-Length header when missing ([#175](#175)) ([c2f416b](c2f416b))
@snyk-bot snyk-bot mentioned this pull request Jan 24, 2020
Open
OneDev0411 added a commit to OneDev0411/serverless-express that referenced this pull request Mar 16, 2023
@OneDev0411
chore(release): version 3.3.5 [skip ci]
0344cce 
<a name="3.3.5"></a>
## [3.3.5](CodeGenieApp/serverless-express@v3.3.4...v3.3.5) (2018-08-20)

### Bug Fixes

* apply Content-Length header when missing ([b0927b8](CodeGenieApp/serverless-express@b0927b8)), closes [#147](CodeGenieApp/serverless-express#147) [#106](CodeGenieApp/serverless-express#106) [#130](CodeGenieApp/serverless-express#130)
* apply Content-Length header when missing ([#175](CodeGenieApp/serverless-express#175)) ([c2f416b](CodeGenieApp/serverless-express@c2f416b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digioak-zz digioak-zz digioak-zz approved these changes

@keetonian keetonian Awaiting requested review from keetonian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brettstack @digioak-zz @semantic-release-bot