fix: make headers an object instead of an array #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettstack
approved these changes
May 31, 2021
github-actions bot
pushed a commit
that referenced
this pull request
May 31, 2021
## [4.3.8](v4.3.7...v4.3.8) (2021-05-31) ### Bug Fixes * make headers an object instead of an array ([#386](#386)) ([a987fee](a987fee))
|
🎉 This PR is included in version 4.3.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
OneDev0411
added a commit
to OneDev0411/serverless-express
that referenced
this pull request
Mar 16, 2023
## [4.3.8](CodeGenieApp/serverless-express@v4.3.7...v4.3.8) (2021-05-31) ### Bug Fixes * make headers an object instead of an array ([#386](CodeGenieApp/serverless-express#386)) ([a987fee](CodeGenieApp/serverless-express@a987fee))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently, the generated headers look like this:
The headers in
src/event-sources/aws/api-gateway-v2.jsare of type array but should be of type object.TIL: something like
headers['x-forwarded-proto']still returnshttps. But:JSON.stringify(headers)returns an empty array.Checklist
If you think that tests and docs should be added, please let me know.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.