Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "local" scripts to match expectations for "stage" variable in app.js #627

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Update "local" scripts to match expectations for "stage" variable in app.js #627

merged 2 commits into from
Dec 15, 2023

Conversation

thzinc
Copy link
Contributor

@thzinc thzinc commented Feb 2, 2023

Update "local" scripts to match expectations of a "stage" variable in UI

When running npm run start, which runs the local Express server on localhost:3000, the stage variable was not set and the routes were not configured to support an extra path element. This change uses the value Stage and mounts the example app at /Stage, as well as adds a redirect from / to /Stage

Before

Screenshot of broken page

After

Screenshot of working page

Checklist

  • Tests have been added and are passing
    • No test suite appears to apply here
  • Documentation has been updated
    • This example code appears to serve as documentation itself

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thzinc thzinc marked this pull request as ready for review February 2, 2023 00:12
@brettstack brettstack merged commit 2fcb68d into CodeGenieApp:mainline Dec 15, 2023
0 of 4 checks passed
Copy link

🎉 This PR is included in version 4.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants