mutation: Use chunk-based mutation approach for Map #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mutator tended to generate arrays of length almost 1000 very quickly, which is unnecessary in tests and also doesn't match the actual behavior at runtime.
Makes it possible to run the tests without building proto-related code.
fmeum
force-pushed
the
FUZZ-659-map-fixes
branch
2 times, most recently
from
cdf2fcc
to
253c26a
Compare
|
I submitted bazel-contrib/rules_jvm#175 to get better logs and noticed that there is an OOM issue that I will need to investigate. |
fmeum
force-pushed
the
FUZZ-659-map-fixes
branch
from
253c26a
to
d3dc77b
Compare
src/main/java/com/code_intelligence/jazzer/mutation/mutator/collection/ChunkMutations.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/mutator/collection/ChunkMutations.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/mutator/collection/ChunkMutations.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/mutator/collection/MapMutatorFactory.java
Outdated
Show resolved
Hide resolved
fmeum
force-pushed
the
FUZZ-659-map-fixes
branch
2 times, most recently
from
93940bd
to
93b60ee
Compare
fmeum
force-pushed
the
FUZZ-659-map-fixes
branch
from
93b60ee
to
7e4c31c
Compare
The previous Map mutator performed both single element as well as chunk mutations, which isn't necessary now that we can bias chunks towards being small. The old implementation didn't check that `initInPlace` and `read` obeyed the specified `minSize`. Since non-zero `minSize`s can be problematic in `read`, they are not supported for now. There were also a few issues with key mutations: Instead of retrying key creation separately for each key, which can result in a large amount of wasted attempts if the key set is almost saturated, all such attempts now share a single failure counter. Keys are now properly detached before being mutated, which is necessary if map keys are mutable. The fallback to value mutation if key mutation failed also didn't behave correctly: It called `setValue` on a newly allocated `Map.Entry`, which is a noop. The number of iterations in the StressTest is halved to prevent OOMs on the runners.
fmeum
force-pushed
the
FUZZ-659-map-fixes
branch
from
7e4c31c
to
f1f11db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous Map mutator performed both single element as well as chunk
mutations, which isn't necessary now that we can bias chunks towards
being small.
The old implementation didn't check that
initInPlaceandreadobeyedthe specified
minSize. Since non-zerominSizes can be problematic inread, they are not supported for now.There were also a few issues with key mutations: Instead of retrying key
creation separately for each key, which can result in a large amount of
wasted attempts if the key set is almost saturated, all such attempts
now share a single failure counter. Keys are now properly detached
before being mutated, which is necessary if map keys are mutable.
The fallback to value mutation if key mutation failed also didn't
behave correctly: It called
setValueon a newly allocatedMap.Entry,which is a noop.